react-use icon indicating copy to clipboard operation
react-use copied to clipboard

feat: Add support for using useEnsuredForwardedRef with callback refs

Open n4bb12 opened this issue 4 years ago • 1 comments

Description

Based on this suggestion this adds support for using useEnsuredForwardedRef with callback refs and adds a test to cover it.

Resolves #805

Drafted because I'm checking coverage.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • [x] Read the Contributing Guide
  • [x] Perform a code self-review
  • [x] Comment the code, particularly in hard-to-understand areas
  • [x] Add documentation
  • [x] Add hook's story at Storybook
  • [x] Cover changes with tests
  • [x] Ensure the test suite passes (yarn test)
  • [x] Provide 100% tests coverage
  • [x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • [x] Make sure types are fine (yarn lint:types).

n4bb12 avatar Feb 10 '21 20:02 n4bb12

Any reason this couldn't be merged?

(Sorry for resurrecting such an old PR! 😅)

Merott avatar Aug 16 '23 19:08 Merott