rabbit icon indicating copy to clipboard operation
rabbit copied to clipboard

Established connections exit when Mode=Both

Open DemonZack opened this issue 3 years ago • 3 comments

When Mode=Both, connections that have already been established exit. Normally, Both Close and Stop() cannot exit properly

Close() notifies watchNotifyClose and reestablishes the connection. Stop() only exits Consumer, but Producter does not exit properly

Therefore, it is recommended to adjust at watchNotifyClose and then complete consumer and producer exit via Close() or Stop()

image

DemonZack avatar Aug 15 '22 07:08 DemonZack

Great call! Will update and create a new release. Thank you!

dselans avatar Aug 15 '22 17:08 dselans

Not at all. It's my pleasure.

DemonZack avatar Aug 17 '22 00:08 DemonZack

Wow, I think we totally missed this. We are currently testing out rabbit's official go lib and will update this afterwards.

Sorry about that!

dselans avatar Dec 27 '22 20:12 dselans