stream-utils
chore: bump iconv-lite from 0.4.24 to 0.5.0
Looks like that will need to be a major version bump for this module, as 0.5.0 changes the minimum Node.js version to 0.10 (vs the 0.8 minimum that 1.x of this module has).
@dougwilson Is there any way we can get this dep updated? Current latest version is at 0.6.3, so this PR should even be updated. The 0.4.x line of iconv-lite causes a deprecation warning due to new Buffer(0).
The 0.4.x line of iconv-lite causes a deprecation warning due to new Buffer(0).
I haven't heard of that or seen it before. If this is accurate I would not have let this languash. Can you provide a reproduction case of that deprecation through this module? It doesn't appear in our test suite, so we are clearly miasing some sort of test we'd want to get added too.
The usage should have been fixed in version 2.3.3 of this module (https://github.com/stream-utils/raw-body/blob/master/HISTORY.md#233--2018-05-08) and indeed when I run npm test before 2.3.3 I see a deprecation message, but 2.3.3+ there is none. Is there another one somewhere? A reproduction case for this issue would be a big help, especially since I see no changes in the iconv-lite dependency that would have fixed any new Buffer(0) issue that we could pull in that we don't already have (or maybe link to the commit in iconv-lite that is the fix you are referring to?).
My apologies. Turns out we were using an older version of raw-body that in turn was using an older iconv-lite. Indeed the latest version of raw-body does not suffer from the deprecation warning.