desktop icon indicating copy to clipboard operation
desktop copied to clipboard

fix(build): react-devtools build folder was ignored

Open blackxored opened this issue 1 year ago • 2 comments

React DevTools build folder was ignored from one of our global patterns. Didn't realize this until I had to reclone the repo.

blackxored avatar Feb 27 '24 20:02 blackxored

BundleMon

Unchanged files (4)
Status Path Size Limits
:white_check_mark: renderer.(hash).js
6.72MB -
:white_check_mark: vendors~renderer.(hash).js
4.69MB -
:white_check_mark: updater.js
115.28KB -
:white_check_mark: guest-api.js
40.19KB -

No change in files bundle size

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

bundlemon[bot] avatar Feb 27 '24 20:02 bundlemon[bot]

There's a CSRF issue identified so it might not be as simple of a review. I don't believe the param is actually user-provided but dynamically generated by the extension to work, looking like a false positive. That said, considering this and also that React Devtools doesn't work without allowFileAccess we should take extra care.

EDIT: ~marked as on hold~ converted to Draft to avoid merge.

blackxored avatar Feb 27 '24 23:02 blackxored