desktop
desktop copied to clipboard
stream-labs
Added support for virtual camera toggle hot key
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
BundleMon
Files updated (2)
| Status | Path | Size | Limits |
|---|---|---|---|
| :white_check_mark: | vendors~renderer.(hash).js |
5.02MB (+18.03KB +0.35%) | - |
| :white_check_mark: | renderer.(hash).js |
6.07MB (+1.94KB +0.03%) | - |
Unchanged files (2)
| Status | Path | Size | Limits |
|---|---|---|---|
| :white_check_mark: | updater.js |
114.99KB | - |
| :white_check_mark: | guest-api.js |
40.18KB | - |
Total files change +19.97KB +0.17%
Final result: :white_check_mark:
View report in BundleMon website ➡️
Current branch size history | Target branch size history
![bundlemon[bot] avatar](https://avatars.githubusercontent.com/in/71110?v=4 "Published by a pub.dev verified publisher"){kind=small}
Any particular reason why the build validation failed? Can't seem to see the error.
Commenter does not have sufficient privileges for PR 4200 in repo stream-labs/desktop
@andycreeth I have committed again with a fix for why the pipelines failed
Hey @ryanfalzon thanks for your submission! I had our QA team test this branch, and one thing they noted is that this toggle doesn't work if you assign both start and stop to the same hotkey (therefore acting as a toggle). This should start working if you define isActive on these hotkey actions. These functions should just return true/false based on whether that action is already active and shouldn't be applied. So for example for TOGGLE_VIRTUAL_CAMERA_ON, isActive would return true if the virtual camera is already on. And inversely, for TOGGLE_VIRTUAL_CAMERA_OFF, isActive would return true if the virtual camera is already off.
Once you add this, the hotkey should start working as a toggle if you binding both actions to the same key. Let me know if that doesn't make sense.
Thanks again for your contribution and we would be happy to merge this once the above change is made.
@andycreeth thanks for the feedback and sorry took so long to get back to you but have been busy with other projects. I have implemented the requested update and have pushed the changes. Let me know if there are any further issues with my PR.
@andycreeth just checking... was this PR merged or do I need to do anything else?