django-gcloud-storage icon indicating copy to clipboard operation
django-gcloud-storage copied to clipboard

Use core django for caching signed urls.

Open scattym opened this issue 6 years ago • 1 comments

Use the caching feature of django core to cache urls. Using this feature we can create multi-day urls and keep them cached in whatever caching backend is configured. May only help in certain use cases, but one of those use cases is mine :)

scattym avatar Mar 30 '18 10:03 scattym

Hey, thanks for the PR! I'm a bit busy because of Easter holidays, but I'll try to look into this soon!

This should also be included in the unit tests, especially for covering multiple Django versions. I should update those for recent Django versions anyway, now that I think about it.

Am 30. März 2018 12:11:33 MESZ schrieb Matt Clark [email protected]:

Use the caching feature of django core to cache urls. Using this feature we can create multi-day urls and keep them cached in whatever caching backend is configured. May only help in certain use cases, but one of those use cases is mine :) You can view, comment on, or merge this pull request online at:

https://github.com/Strayer/django-gcloud-storage/pull/13

-- Commit Summary --

  • Use core django for caching signed urls.

-- File Changes --

M django_gcloud_storage/init.py (43)

-- Patch Links --

https://github.com/Strayer/django-gcloud-storage/pull/13.patch https://github.com/Strayer/django-gcloud-storage/pull/13.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/Strayer/django-gcloud-storage/pull/13

strayer avatar Mar 30 '18 10:03 strayer