random-scripts icon indicating copy to clipboard operation
random-scripts copied to clipboard

Various fixes

Open Coder666 opened this issue 8 years ago • 1 comments

Fixed an issue with sending mail to non-email addresses. Added noddy @ check. Fixed issue with repeated random numbers Fixed an issue with UTF-8 characters in subject lines i.e £ sign Added a zero padded random integer replacement

Coder666 avatar Jan 31 '17 16:01 Coder666

Dictionary is being used as a lookup table. List lookups are O(n) whereas dictionary lookups are O(1) so it makes more sense speed wise to use a dictionary.

Well, I just had some images with padded integer numbers 0000blah.png so needed this. I don't think it does any harm.

I also have a fix for using google smtp which requires starttls which I will commit later

Tom

Get Outlook for iOShttps://aka.ms/o0ukef


From: Iain Wallace [email protected] Sent: Wednesday, February 1, 2017 10:32:49 AM To: strawp/random-scripts Cc: Tom; Author Subject: Re: [strawp/random-scripts] Various fixes (#1)

@strawp commented on this pull request.

Thanks!

  1. Why is the usedints a dict? Isn't it just a list?
  2. Is it the intended behaviour to have two separate random ints per email or would it be better to just pad the first random int in order to fill {randomintpadded}?

You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/strawp/random-scripts/pull/1#pullrequestreview-19519939, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARJh6P9waUnQXiKurBqOkvLUuNHF9pBLks5rYF9RgaJpZM4Ly105.

Coder666 avatar Feb 01 '17 14:02 Coder666