William Easton comments

Results 215 comments of


                                            William Easton

Update doc site for 2.0 release

I think we're also missing some useful common fields like device name

`hass.object_id` should be a property of the `entity`

Sounds good, I can include this in one of my PRs coming up!

`hass.object_id` should be a property of the `entity`

hass.entity.object.id? or object_id?

[8.14] Fix handling of custom Endpoint when using S3 + SQS

@cmacknz added additional tests

Cannot use a custom Endpoint with SQS

proposed PR https://github.com/elastic/beats/pull/39709

Cannot use a custom Endpoint with SQS

Yes this can be closed now in favor of the issue @pierrehilbert referenced

Issues with SQS custom endpoint setup on Main

@faec

Issues with SQS custom endpoint setup on Main

Related to https://github.com/elastic/beats/issues/39706 and https://github.com/elastic/beats/pull/39709

[main] Fix handling of custom Endpoint when using S3 + SQS

@faec can we make sure these items are fixed in your refactor as well? i.e. the ones in https://github.com/elastic/beats/pull/39709 that arent already fixed?

[main] Fix handling of custom Endpoint when using S3 + SQS

this was not supposed to merge, it was just an example for how to include it post s3/sqs refactor, ill close the PR