strawberry icon indicating copy to clipboard operation
strawberry copied to clipboard

Input extensions

Open basvandriel opened this issue 1 year ago • 4 comments

Basic dict support for input extensions, to support automatic persisted queries in the future. See #1707.

Description

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [x] Enhancement/optimization
  • [ ] Documentation

Issues Fixed or Closed by This PR

  • #3296

Checklist

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

basvandriel avatar Dec 17 '23 20:12 basvandriel

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Related to #1707. This requires support for the underneath example in the curl command. See the documentation here.

curl --get http://localhost:4000/graphql \
  --header 'content-type: application/json' \
  --data-urlencode 'extensions={"persistedQuery":{"version":1,"sha256Hash":"ecf4edb46db40b5132295c0291d62fb65d6759a9eedfa4d5d612dd5ec54a6b38"}}'

Here's the tweet text:

🆕 Release (next) is out! Thanks to @bvandriel for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

botberry avatar Dec 17 '23 20:12 botberry

CodSpeed Performance Report

Merging #3297 will not alter performance

Comparing basvandriel:feature/inputextensions (c807d44) with main (aad305b)

Summary

✅ 11 untouched benchmarks

codspeed-hq[bot] avatar Dec 17 '23 20:12 codspeed-hq[bot]

Codecov Report

Merging #3297 (3587bd3) into main (e4fe4fc) will decrease coverage by 0.21%. The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3297      +/-   ##
==========================================
- Coverage   96.61%   96.41%   -0.21%     
==========================================
  Files         483      483              
  Lines       30188    30197       +9     
  Branches     3729     3731       +2     
==========================================
- Hits        29167    29115      -52     
- Misses        832      893      +61     
  Partials      189      189              

codecov[bot] avatar Dec 17 '23 20:12 codecov[bot]

Can someone take a look at this PR? Tests in tests/websockets/test_graphql_transport_ws.py seem to be failing in the CI which I can't replicate locally. cc @patrick91

basvandriel avatar Dec 20 '23 16:12 basvandriel