strawberry-django
strawberry-django copied to clipboard
Fixed pagination being added to non list fields with types that have …
…pagination.
Also changed the logic in ordering and filtering to match and keep it consistent.
Made it so that ordering, filtering and pagination are not added to the list, but also that the specific function to get the definition returns None.
Description
Types of Changes
- [ ] Core
- [x] Bugfix
- [ ] New feature
- [x] Enhancement/optimization
- [ ] Documentation
Issues Fixed or Closed by This PR
- #252
Checklist
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [x] I have added tests to cover my changes.
- [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
Hey @hvdklauw ,
Just pinging to check if you still want to finish this issue :) Otherwise I can adjust and merge this for you
Hey, I would, but I'm going on vacation for the next 3 weeks.
So feel free to tweak and merge, otherwise I'll pick it up again when I get back
Hey, I would, but I'm going on vacation for the next 3 weeks.
So feel free to tweak and merge, otherwise I'll pick it up again when I get back
Np, take your time! :)
Hey @hvdklauw ,
I'm almost sure this was already fixed during the time this has been opened by other fixes, and since this has been sitting here for a while I'm going to close it to clear the backlog, ok?
If that's not the case, let me know so we can reopen this :)
Oh sure, np.. I totally forgot about this tbh :D