stratum icon indicating copy to clipboard operation
stratum copied to clipboard

Update P4c dependency and remove #undefine logging.h workaround

Open pudelkoM opened this issue 5 years ago • 2 comments

Has been fixed upstream.

TODO

  • [x] switch back to upstream repos once fixes has been merged

pudelkoM avatar Sep 02 '20 21:09 pudelkoM

no issues from my side

bocon13 avatar Sep 03 '20 20:09 bocon13

Some tests are failing and I pinned it down to this upstream change: https://github.com/p4lang/p4c/pull/2108

Seems like p4c changed some transforms:

 if (table.apply().hit) {
   ...
 }
into:
 bool hit_tmp = table.apply().hit;
 if (hit_tmp) {
   ...
 }

This no longer happens, as they are now preserved as is. Our custom TableHitStatement is no longer needed and we could try to remove it from the code base.

pudelkoM avatar Sep 10 '20 02:09 pudelkoM