fabric-tna icon indicating copy to clipboard operation
fabric-tna copied to clipboard

Increase table size

Open ccascone opened this issue 4 years ago • 4 comments

Current sizing is the default for the bmv2 build of the old fabric-v1model, which is too small. We have plenty of memory resources to make our tables bigger without worrying about pipeline optimizations.

Not sure why we abandoned #6

ccascone avatar Oct 02 '20 02:10 ccascone

Just providing numbers for record - in current scale, we have ~ 120 groups in a leaf switch. The group limit is 1024, which means we will hit the limit if ONOS is restarted 8~9 times.

charlesmcchan avatar Oct 02 '20 02:10 charlesmcchan

Any chance we can make ONOS remove extraneous groups?

ccascone avatar Oct 02 '20 02:10 ccascone

Just providing numbers for record - in current scale, we have ~ 120 groups in a leaf switch. The group limit is 1024, which means we will hit the limit if ONOS is restarted 8~9 times.

Correction: 120 groups is likely caused by ONOS pod being restarted by k8s without restarting Atomix as well. In a clean setup, the group count should look like this:

karaf@root > groups -c                                                                                                                                                       03:17:38
deviceId=device:leaf1, groupCount=12
deviceId=device:leaf2, groupCount=6
deviceId=device:spine2, groupCount=4

charlesmcchan avatar Oct 02 '20 03:10 charlesmcchan

Any chance we can make ONOS remove extraneous groups?

We can try a feature that remove groups with 0 reference count. However, the reference count is not reported correctly today so we have to fix that first. Every group has 0 reference count.

charlesmcchan avatar Oct 02 '20 03:10 charlesmcchan