StratosphereLinuxIPS icon indicating copy to clipboard operation
StratosphereLinuxIPS copied to clipboard

the tell_pbar() shouldn't forward empty msgs to the progress bar

Open AlyaGomaa opened this issue 1 year ago • 2 comments

AlyaGomaa avatar Jul 30 '24 14:07 AlyaGomaa

Hey @AlyaGomaa, I can work on this. From my understanding it is a simple fix. Steps to fix it

  1. Add a condition in tell_pbar() function to check if msg is empty or not before calling pbar_send_pipe function.
  2. Modify test_output.py to test this. It will require modification for both test_tell_pbar_empty_message() and test_tell_pbar_none_message().

patel-lay avatar Aug 13 '24 23:08 patel-lay

hi @patel-lay yes you're correct

AlyaGomaa avatar Aug 16 '24 14:08 AlyaGomaa