Added more tests to test_http_analyzer.py
Fixes Issue #571
This pull request adds more tests for http_analyzer.py
- [x] My code follows the code style of this project.
- [ ] My change requires changes to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] All new and existing tests passed.
- [x] This PR does not contain plagiarized content.
- [x] The title of my pull request is a short description of the requested changes.
Hey @AlyaGomaa Will this be enough? It is not showing a PEP8 error in PyCharm. Please tell me if further shortening of lines is required.
Hello @Sekhar-Kumar-Dash thanks for reformatting your code and the awesome PR!
quick question, are pre-commit hooks working for you?
i'm getting the following errors preventing me from commiting your code. they're duplicate functions
you can install them using
python3 -m pip install pre-commitpre-commit install(this will install the hooks in the .pre-commit-config.yaml in slips repo)
i highly recommend you set them up in pycharm like so https://stackoverflow.com/questions/76062147/how-to-run-pre-commit-on-current-active-file-in-pycharm/76067185#76067185 now pycharm will reject commits with issues until you fix them, and sometimes it will re-format your commits automatically so you woudn't have to waste time on code formatting.
Hey @AlyaGomaa , thank you for this great suggestion. I am working on it. I will let you know.
Hey @AlyaGomaa , I just removed the duplicates manually as I'm having some issues running the pre-commit right now. Please take a look
hey @AlyaGomaa just made the changes please review it
hey @Sekhar-Kumar-Dash thanks for the changes, i think everything looks good now, i'll merge once the tests pass! keep up the great work!