stratosphereips
Added more tests to test_whitelist.py
Fixes Issue #564
This pull request adds more tests for whitelist.py
- [x] My code follows the code style of this project.
- [ ] My change requires changes to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] All new and existing tests passed.
- [x] This PR does not contain plagiarized content.
- [x] The title of my pull request is a short description of the requested changes.
That's strange. It was working completely when I tested it locally.
i think it is beacause of some recent changes that were made to whitelist.py
@Sekhar-Kumar-Dash they're failing locally in my computer too!
However when i checked your code i noticed the following
see the vertical light gray line on the right? you have to click on the photo to see it. this is the line max length. i see your code doesn't follow PEP's max line char per line, you can configure your IDE to display it then i will re-review your PR and we can dbeug what went wrong
hey @AlyaGomaa Just updated this PR. Actually the problem was that there was a mismatch between my version of the code and the latest version of the code
Hey @AlyaGomaa , it is saying the process is canceled. I could not get it. Did it happen because of errors in the code?
@Sekhar-Kumar-Dash i don't know that was weird, but no this is not coming from your code. i restarted CI and we'll see
hey @AlyaGomaa Just updated the test file please check now we are getting only three error with ruff hook.I think we can ignore them
Hello @Sekhar-Kumar-Dash i added some comments, please don't start resolving them until i push my refactoring for whitelist.py so we can better test large functions. thanksssss
Okay