StratosphereLinuxIPS icon indicating copy to clipboard operation
StratosphereLinuxIPS copied to clipboard

Updated and added more tests to test_flow_handler.py

Open Sekhar-Kumar-Dash opened this issue 1 year ago • 3 comments

Fixes Issue #562

Changes proposed

This pull request adds more tests for flow_handler.py

Check List (Check all the applicable boxes)

  • [x] My code follows the code style of this project.
  • [ ] My change requires changes to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [x] This PR does not contain plagiarized content.
  • [x] The title of my pull request is a short description of the requested changes.

Sekhar-Kumar-Dash avatar Apr 18 '24 15:04 Sekhar-Kumar-Dash

Hello @Sekhar-Kumar-Dash I see your code still has the issue of long lines. max line chars should be 78 chars. Can you please configure your IDE to user PEP8 style guide? Thanks for your PR! i will re-review again when you fix all calls to cassert_called_with() with ANY parameter.

hey @AlyaGomaa PYcharm is showing just one PEP8 style error
image Are you getting more errors in your IDE? Anyway, I will further shorten the long lines.

Sekhar-Kumar-Dash avatar Apr 24 '24 14:04 Sekhar-Kumar-Dash

@AlyaGomaa I have just updated the pull request, and I used asdict as it was throwing an assertion error when using dict. Please check the code.

Sekhar-Kumar-Dash avatar Apr 24 '24 14:04 Sekhar-Kumar-Dash

Hello @Sekhar-Kumar-Dash. checkingg

AlyaGomaa avatar Apr 26 '24 13:04 AlyaGomaa

Hey @Sekhar-Kumar-Dash thanks for the awesome PR! we appreciate it!

AlyaGomaa avatar Apr 29 '24 14:04 AlyaGomaa