StratosphereLinuxIPS icon indicating copy to clipboard operation
StratosphereLinuxIPS copied to clipboard

Added more tests to test_slips_utils.py

Open Sekhar-Kumar-Dash opened this issue 1 year ago • 5 comments

Fixes Issue #523

Changes proposed

This pull request adds more tests for slips_utils.py

Check List (Check all the applicable boxes)

  • [x] My code follows the code style of this project.
  • [ ] My change requires changes to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.
  • [x] This PR does not contain plagiarized content.
  • [x] The title of my pull request is a short description of the requested changes.

Sekhar-Kumar-Dash avatar Apr 09 '24 15:04 Sekhar-Kumar-Dash

hey @Sekhar-Kumar-Dash i will re-review your PR after using @pytest.mark.parametrize everywhere, you can use it whenever you start calling the same function you're testing more than once in the same unit tests with different params.

you can read more about it here https://docs.pytest.org/en/7.1.x/how-to/parametrize.html#pytest-mark-parametrize-parametrizing-test-functions

Thanks for the hard work! we appreciate it.

Hey @AlyaGomaa , Thanks for the suggestion , I will use parametrize and update this PR soon. I will also keep this in mind for future unit test PRs. First, I thought you wanted me to use parametrize for each test you commented, but now I understand that you want me to combine similar tests into one using parametrize. Please ignore my recent changes to this PR

Sekhar-Kumar-Dash avatar Apr 17 '24 18:04 Sekhar-Kumar-Dash

hey @AlyaGomaa just updated the PR please take a look

Sekhar-Kumar-Dash avatar Apr 18 '24 14:04 Sekhar-Kumar-Dash

Hello @Sekhar-Kumar-Dash the unit tests for slips_utils.py are failing

AlyaGomaa avatar Apr 26 '24 13:04 AlyaGomaa

hey @AlyaGomaa I was not getting these errors locally, but I fixed it by looking into the assertion errors please take a look

Sekhar-Kumar-Dash avatar Apr 26 '24 14:04 Sekhar-Kumar-Dash

hey @AlyaGomaa I made the required changes please review it

Sekhar-Kumar-Dash avatar May 28 '24 14:05 Sekhar-Kumar-Dash

hey @Sekhar-Kumar-Dash theres a problem with slips utils tests

AlyaGomaa avatar Jul 01 '24 20:07 AlyaGomaa

hey @Sekhar-Kumar-Dash theres a problem with slips utils tests

hey @AlyaGomaa thanks i am taking a look into it

Sekhar-Kumar-Dash avatar Jul 02 '24 04:07 Sekhar-Kumar-Dash

wohooo finally merged! thanks for the PR @Sekhar-Kumar-Dash

AlyaGomaa avatar Jul 15 '24 14:07 AlyaGomaa