stratisd icon indicating copy to clipboard operation
stratisd copied to clipboard

Replace invocatins to thin-provisioning-tools with native rust binding

Open NickCao opened this issue 3 years ago • 5 comments

Related https://github.com/stratis-storage/project/issues/383

NickCao avatar Aug 03 '22 05:08 NickCao

Just noticed that stratisd is published on crates.io, so maybe git deps is a no go?

NickCao avatar Aug 03 '22 12:08 NickCao

@NickCao Thanks for the PR! Unfortunately, the Cargo.toml change will make Fedora packaging impossible. It's a change we have wanted to make though, so we'll check into some of the ideas we were offered, and may be able to find a solution that will push it to completion. But this will take a bit longer.

mulkieran avatar Aug 03 '22 12:08 mulkieran

Just noticed that stratisd is published on crates.io, so maybe git deps is a no go?

I guess that, too!

mulkieran avatar Aug 03 '22 12:08 mulkieran

Some expected but some interesting errors. We got a stack overflow in one place, which is unusual.

mulkieran avatar Aug 03 '22 16:08 mulkieran

The current implementation is not 100% percent identical to the rust based cli, lacking some sanity checks, let alone the difference from the c version.

NickCao avatar Aug 03 '22 16:08 NickCao

@NickCao Do you mind if I close this? It's still a goal for us, but our code has moved on and the PR has gained some significant conflicts.

mulkieran avatar Nov 18 '22 14:11 mulkieran