Hauke Strasdat

When designing image types (e.g. https://github.com/strasdat/Sophus/blob/23.04-beta/cpp/sophus/image/image_view.h#L125), I came to the same conclusion that signed integer pixel coordinates are beneficial. For instance, it is quite useful/common to ask whether a 3d...

@fintelia, @HeroicKatora - thanks for insightful discussion and feedback. My current use-case is unblocked by #1847, so no urgency from my end.

@FrankXie05, sorry it has been some time, and I just pushed a larger update (#538). If you are still interested, I'd be happy to coordinate...

@FrankXie05 thanks for the PR! I think I'm a little confused since I would have expected a vcpk.json in the root of the Sophus repository. Maybe it got deleted at...

> A library shall never ever call std::abort(), std::terminate(), std::exit(), Well, in c++ libraries can do anything when preconditions are violated. In my opinion, calling abort is much better than...

@TLescoatTFX, thanks for you candid feedback. So let me elaborate. In sophus, NAN's on input variables are undocumented (I have to admit) precondition violations. When I will find some time,...

> abort() gets in the way of debuggers, while also hiding the error. I just tried it out and I'm getting this stack-trace in GDB with the corresponding line number...

The PR above includes an example of how to use a custom SOPHUS_ENABLE_ENSURE_HANDLER and hence throw an exception instead of calling std::abort: https://github.com/strasdat/Sophus/blob/ae3a9041e970e07b39ae015d3ebbb6a229f4a688/examples/CMakeLists.txt#L16

won't fix, see: #538

Thanks for reporting!