strapi icon indicating copy to clipboard operation
strapi copied to clipboard

chore(i18n): Adding Hungarian translation for admin core

Open popovicsandras opened this issue 1 year ago • 4 comments

What does it do?

Adding Hungarian translation texts for Admin Core features, which were missing from Strapi 4.20.0.

  1. Started from this PR, I've rebased it, while paying attention to keep the commit history, giving the credits for @KristofKekesi for his work.
  2. On top of his work, I've added all the missing translation keys, while reordering the keys to have the same order that the en.json translation file has.

Why is it needed?

Hungarian translation for Admin Core features was partial.

How to test it?

Run the application using Hungarian language.

Related issue(s)/PR(s)

https://feedback.strapi.io/feature-requests/p/i18n-hungarian-translation

popovicsandras avatar Feb 14 '24 17:02 popovicsandras

CLA assistant check
All committers have signed the CLA.

strapi-cla avatar Feb 14 '24 17:02 strapi-cla

@innerdvations, @alexandrebodin Sorry for the direct tagging, I've seen your names in another community created PRs. Can you please point me to someone who I can bother with these 2 (this and https://github.com/strapi/strapi/pull/19522 ) only translation related PRs (no code change at all)? I keep rebasing them to be uptodate and I just would like to know how much time usually it takes to be merged, whether I should keep them rebased or not.

Cheers, Andras

popovicsandras avatar Feb 20 '24 09:02 popovicsandras

@derrickmehaffy, Sorry for the direct tagging, I'm pretty sure you are busy with another PRs, but I've seen your name in another community created PRs. I keep rebasing these 2 PRs for 2 weeks now (this and https://github.com/strapi/strapi/pull/19522) without any feedback from Strapi's side, can someone please tell me whether it makes sense for me to keep it updated? It didn't get any feedback or change request, nor a label or something (to postpone, etc...) Do you consider it a meaningful contribution? Saying no is completely fine for me, I just would like to know whether it is worth my effort to keep this branch uptodate.

Kind regs, Andras

popovicsandras avatar Mar 02 '24 19:03 popovicsandras

As a fellow Hungarian I commend your work here @popovicsandras! I certainly hope this PR will soon gain traction among the maintainers.

truumahn avatar Mar 21 '24 14:03 truumahn