foodadvisor
foodadvisor copied to clipboard
strapi
Demo/publication system workflow
@dennism501, would you have some time to review this? I fixed a lot of issues, added new users, etc...
Might be outside your scope @Mcastres but could be cool to build some conditionals with this :thinking:
Hey 👋 Sorry, it seems that I'm out of the loop here. Could you please tell me a bit more about this PR? I'm not sure what has changed, what was the state before and why did it need changing. Also, how would you like this to be tested? Thank you 😊
Sure! Thanks @ivanThePleasant for taking the time to review this! I really appreciate it
A lot of things changed:
- You don't create the first admin anymore but have pre-created users (credentials in README) in order to provide a better experience inside of the app with an editor and an author users.
- Introduction of a publication workflow workaround system (see README)
- Added some plugins from the Marketplace
That is pretty much it. You can test the app by logging as the author, create a new article, and putting it the In review state for the publicationState field. Then log as the editor, see if the article listView page shows you a button allowing you to directly filter the In review articles. Update the article by request changes, still using the publicationStage field etc...
Create restaurants, update some, delete some and that should be good. Also, check if the plugins don't break anything.
What do you mean exactly @derrickmehaffy?
https://docs.strapi.io/developer-docs/latest/setup-deployment-guides/configurations/optional/rbac.html#declaring-new-conditions
Basically forcefully limiting what a certain user/role can do depending on states, ect. Adding security to the usability
Hopefully I can test and review this later today, it's a busy week for me sadly :/
@Mcastres the seeding script is broken, but I presume because you already have seeded data on your machine, you would not notice that. I can see that you've switched to better-sqlite3, but the seed script for yarn seed is looking for sqlite3
@Mcastres I noticed some text artifacts on the Content Manager page and also ER chart is throwing an error if you press "Switch to API preview". Is this expected behavior at the moment?
Did you yarn? Because I removed the ER chart plugin already.
Should be good for the text overlapping, it was because the uploads folder wasn't correctly copied
I did. Don't know why it's there, but it's still there. But anyway, apart from that it seems to be all ok 👍
Not sure if it's related but the cal plugin isn't working (it's cool btw, I might use this for a personal to-do / weekly tracker :thinking:
What is not working in the calendar plugin @derrickmehaffy?
It's not showing any articles scheduled to be published.
It is good to go @derrickmehaffy?
Yeah it's fine, the other best practices suggestions I made I'll just do myself in another PR.