documentation icon indicating copy to clipboard operation
documentation copied to clipboard

updated controllers doc

Open omerfaran opened this issue 2 years ago • 8 comments

What does it do?

Describe the technical changes you did.

Added a paragraph inside the controllers docs, explaining that you would also need to create a route for the controller, and also referring the user to "strapi generate" option;

(PLEASE NOTE: Prettier also formatted some code in the file, it's not related to the PR, would like to merge this too?)

Why is it needed?

Describe the issue you are solving.

Hopefully provides better understanding of the whole picture

Related issue(s)/PR(s)

Would close issue #957 :-)

omerfaran avatar Jun 30 '22 23:06 omerfaran

CLA assistant check
All committers have signed the CLA.

strapi-cla avatar Jun 30 '22 23:06 strapi-cla

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
documentation ✅ Ready (Inspect) Visit Preview Jun 30, 2022 at 11:50PM (UTC)

vercel[bot] avatar Jun 30 '22 23:06 vercel[bot]

Thank you very much for creating this PR, @omerfaran, which would help close issue #957. After discussing it with our devs, this is slightly more complex than I thought, as it really depends on how you create the controllers and which type of controllers you create or customize 😅 So I'll do some tests and get back to you to see how we can improve explanations even further. 🤓

pwizla avatar Jul 01 '22 12:07 pwizla

Hey @pwizla for sure no problem! Would love to contribute more if needed, let me know(:

omerfaran avatar Jul 02 '22 01:07 omerfaran

Hi @omerfaran. I just wanted to follow up on this PR and let you know that I don't forget it. Lots of other priorities to deal with and this week will be shorter for me as French Strapi employees will be off Thursday and Friday. This is added to my to-do list for next week, I'll keep you posted. Thanks for your understanding :)

pwizla avatar Jul 11 '22 14:07 pwizla

Hey @pwizla yes of course that's no problem at all, just let me know And thanks for keeping my posted(:

omerfaran avatar Jul 13 '22 15:07 omerfaran

Still haven't found time to work on this one @omerfaran, as I have pretty limited bandwidth at the moment… I'm pushing it to the next milestone (4.3.1), and we'll take care of it once other technical writers are back from vacation (starting next week 😄)

pwizla avatar Jul 26 '22 14:07 pwizla

Hey @pwizla sure no problem (: thanks for letting me know

omerfaran avatar Jul 27 '22 17:07 omerfaran

HI @omerfaran. I'll merge this one today, we could still expand it eventually if we need to. Thank you again very much for your contribution, and my dearest apologies that it took so long to handle. We'll do better next time! 🚀

pwizla avatar Oct 19 '22 09:10 pwizla

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/new-documentation-release-strapi-v4-4-4/22961/1

strapi-bot avatar Oct 19 '22 12:10 strapi-bot