design-system
design-system copied to clipboard
Cleaning and/or solving the frontend tests (warning/logs)
What does it do? It tries to remove all the warnings in the unit tests and e2e tests
Why is it needed? to have proper logs when running the tests
How to test it? you can run both the tests with these commands Try to remove the warnings, prevent errors and warnings from the:
unit tests, you can run them with the command
yarn test:watch
E2E tests, you can run them with the command
yarn test:e2e
Related issue(s)/PR(s)
It is related to this ticket https://strapi-inc.atlassian.net/jira/software/c/projects/DX/boards/9?modal=detail&selectedIssue=DX-465
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
design-system | ✅ Ready (Inspect) | Visit Preview | Oct 18, 2022 at 10:15AM (UTC) |
design-system-website | ✅ Ready (Inspect) | Visit Preview | Oct 18, 2022 at 10:15AM (UTC) |
In the case of elements like RawTable
, whilst we're using prop-type
they will fail because of this: https://github.com/facebook/react/issues/6653#issuecomment-215793856
They're not necessarily fixable imo, I don't think certain props should have a default because then the warnings aren't flagged for users 🤔 not sure your thoughts on this?