strapi-provider-upload-google-cloud-storage icon indicating copy to clipboard operation
strapi-provider-upload-google-cloud-storage copied to clipboard

doesn't implement the uploadStream function. Some performance issues may occur

Open qhoirulanwar opened this issue 2 years ago • 8 comments

yarn run v1.22.15 $ strapi develop (node:14656) Warning: The upload provider "@strapi-community/strapi-provider-upload-google-cloud-storage" doesn't implement the uploadStream function. Strapi will fallback on the upload method. Some performance issues may occur. (Use node --trace-warnings ... to show where the warning was created) (node:14656) Warning: [deprecated] In future versions, Strapi will stop reading directly from the environment variable API_TOKEN_SALT. Please set apiToken.salt in config/admin.js instead. For security reasons, keep storing the secret in an environment variable and use env() to read it in config/admin.js (ex: apiToken: { salt: env('API_TOKEN_SALT') }). See https://docs.strapi.io/developer-docs/latest/setup-deployment-guides/configurations/optional/environment.html#configuration-using-environment-variables.

Project information

┌────────────────────┬──────────────────────────────────────────────────┐ │ Time │ Thu Apr 21 2022 14:55:30 GMT+0700 (Western Indo… │ │ Launched in │ 32504 ms │ │ Environment │ development │ │ Process PID │ 14656 │ │ Version │ 4.1.8 (node v16.13.1) │ │ Edition │ Community │ └────────────────────┴──────────────────────────────────────────────────┘

Actions available

Is your feature request related to a problem? Please describe. @strapi-community/[email protected] not 100% compatible with [email protected]

Describe the solution you'd like update to latest same version with strapi

qhoirulanwar avatar Apr 18 '22 05:04 qhoirulanwar

I am also getting the same warning. Is there any quick fix for it?

am2222 avatar Apr 23 '22 02:04 am2222

I believe I have a fix for this issue (at least for the missing uploadStream function part), more of a little hack really, but it seems to be working. Should I open a PR @Lith ? Never actually opened one in github before.

What I did was basically add the missing method that calls the old upload method with the file data in the right property.

NunoAraujo avatar Apr 29 '22 11:04 NunoAraujo

Any updates on this one :)?

JulienHe avatar Jun 05 '22 01:06 JulienHe

Hello,

Sorry for delay (again :x) Everyone is free to push PR :)

I will take a look about it this week, but feel free to submit PR. Thx

Lith avatar Jun 06 '22 10:06 Lith

@Lith please check my PR https://github.com/strapi-community/strapi-provider-upload-google-cloud-storage/pull/137

qhoirulanwar avatar Jun 19 '22 15:06 qhoirulanwar

@Lith Hey, when do you think PR might be merged? Basically this issue is breaking plugin usage

RomanLubushkin avatar Jul 04 '22 04:07 RomanLubushkin

I was about to merge this myself when I saw the PR was merged to master. It fixed the big logo upload issue for me. Good work, only wish I had noticed 5 days ago. 😄

digitaldesigndj avatar Jul 20 '22 14:07 digitaldesigndj

This issue should be closed by https://github.com/strapi-community/strapi-provider-upload-google-cloud-storage/pull/137 merged and 4.2.3 released, no ?

qnp avatar Aug 17 '22 08:08 qnp

Hello , I upgraded strapi version to 4.5.5 and this warning appears . Is there any suggestion?

mckaracan avatar Jan 05 '23 13:01 mckaracan

Hello ! Yes this issue should be close... because it's fixed since many month now :]

@mckaracan could you please let me know if the issue is still appears for you with latest release ? Thx.

Lith avatar Jan 19 '23 18:01 Lith

steal appear for me. help please

cyriaque-ovaga avatar Jun 13 '23 23:06 cyriaque-ovaga