pmpro-approvals icon indicating copy to clipboard operation
pmpro-approvals copied to clipboard

Still showing Approve | Deny in front of an approved member on "Approved List" if they have not validated their Email (for Email Confirmation)

Open MaryOJob opened this issue 7 months ago • 1 comments

Describe the bug When using the Email Confirmation Add On on a level that also requires Approval, the Approved List is still showing Approve | Deny in front of an approved member if they have not validated their Email (via Email Confirmation). This can be confusing for the admin, as nothing points to the user's email needing to be validated.

To Reproduce Steps to reproduce the behavior:

  1. Set up a level to require email confirmation and approvals
  2. Check out for a test user and, as an admin, approve the test user (whose email has not been validated)
  3. Go to the Approved List, and you should see the Approve | Deny links present

Screenshots

Expected behavior The Approve | Deny link should not be shown on the Approved List, this should show something like Approved; pending Email Confirmation, or a different message

Isolating the problem (mark completed items with an [x]):

  • [x] I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
  • [x] This bug happens with a default WordPress theme active, or Memberlite.
  • [x] I can reproduce this bug consistently using the steps above.

WordPress Environment

``` WordPress 6.8.1 Paid Memberships Pro 3.4.6 PMPro Approvals 1.6.4 PMPro Email Confirmation 0.8 PHP 8.0.30 Twenty Twenty Theme 2.9 ```

MaryOJob avatar May 12 '25 12:05 MaryOJob

The current flow is to approve the members email first before trying to approve or deny them. This is a bit of a race condition, we can do better to hide approval links until their emails are confirmed.

I've marked this issue as "Needs Thought" so we can discuss the solution a bit more. I could also see a case where if an admin selects "Approve" or "Deny" it could automatically confirm the members email address (for either action or only approved 💡)

andrewlimaza avatar Jun 02 '25 11:06 andrewlimaza