livingcss icon indicating copy to clipboard operation
livingcss copied to clipboard

Published 20 hours ago • verified publisher icon straker

no polymer

Open straker opened this issue 4 years ago • 5 comments

straker avatar Dec 31 '19 21:12 straker

Coverage Status

Coverage remained the same at 97.994% when pulling 467e1fa2f69e63b534e9b9de95ad6190390eb1d2 on noPolymer into ae6ad3f4da9dfaa7e71c59cad9622eb46b2caa2a on master.

coveralls avatar Dec 31 '19 21:12 coveralls

@phun-ky alright, so I'm back at this again during the holiday break and wondering what the performance of your styleguide is if I completely remove Polymer. Almost all major browsers support Web Components and Shadow DOM now, with Edge being the last one and it will get it as soon as it upgrades to the Chromium engine. So I'm able to just use native Shadow DOM to make this work.

straker avatar Dec 31 '19 21:12 straker

Actually, I removed polymer myself, and just using scoped CSS. Works like a charm for my usage. Will see if I can test that branch nevertheless. Happy new year!  null

phun-ky avatar Dec 31 '19 21:12 phun-ky

Oh nice, I didn't know browsers were still supporting that. In that case can I close #71? It was proving difficult trying to get it to work anyway.

straker avatar Dec 31 '19 21:12 straker

I'm not using CSS scope, I just prefix the style guide styles with:  .sg (short for styleguide) and the design system have their own prefix, so styles won't cascade ;)  null

phun-ky avatar Dec 31 '19 22:12 phun-ky