Johannes Müller

Results 822 comments of Johannes Müller

Looking at #10412 again, I think the documentation may need some polishing. Perhaps we should also look at the API/supported features and compare it with prior art. * The Go...

I suppose the question is whether this method should be expected to validate its arguments or not. I think it's not necessary and just avoidable overhead. Of course, it's nice...

https://github.com/crystal-lang/crystal/pull/10412 was reverted in #12517

Ooh, to my knowledge that's the first instance of a problem caused by the fact that the `Crystal` namespace is shared between the stdlib runtime and the compiler. If they...

For reference: Prior discussion in https://forum.crystal-lang.org/t/enums-methods-with-super-previous-def/4302/2

It requires a change in the compiler. So I think this PR still makes sense as an interim solution.

When the `stdout` parameter is an `IO`, the process implementation creates a file system pipe, hands that to the forked process and then spawns a fiber to copy from the...

For reference: This was discovered in https://github.com/crystal-lang/crystal/pull/12456#issuecomment-1250369381

Hm, I suppose `File#delete` just needs to close the file before deleting it on windows? There's also an alternative function for closing files: [`DeleteFileW`](https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-deletefilew). We could consider using this instead...

I'm not sure about this. For example, I would expect such macro loops to have a block macro body similar to the `for` loop: ```cr {% while v < 5...