Johannes Müller

@jgaskins Looks nice. Regarding your questions about the API design, perhaps it makes sense to focus on a very low level API at first. This enables using the feature, but...

How so? I would think this should be perfectly representable in Crystal's type system.

My concern about a structure where query and reading the result are completely separate is that you have to make sure to use the same order in both. But this...

The reason is that timestamp types in posgresql only store the time value with microsecond precision but Crystal's `Time` type has nanosecond precision. `at_end_of_day` results in a time instance with...

Or `Time.utc.at_the_end_of_the_day.at_beginning_of_microsecond` 🤷

Yes, that should fix this problem. There are other implications, though. Truncating the fraction digits results in an odd rounding behaviour that might be unexpected at some times. So I'm...

I haven't looked into the implementation of the extension mechanism and compared it to #89. But I noticed some issues with text representation in `CIText`: * `#hash` should have the...

To summarize from Gitter: Crystal PG doesn't support cleartext auth. It was removed in cafe2a2c90a22595abe1312d330567cd85e683b2 resolving #46. However, that entirely depends on the circumstances. For example, when the connection is...

@will What speaks against enabling this using runtime configuration? I don't think the *developer* of a `crystal-pg`-based app should decide whether cleartext auth is supported, but the actual *user* who...

I'm saying that it shouldn't be determined at compile time, but be configurable at runtime. So you can have a binary that is not *inherently* unsafe, but allows using cleartext...