strager

Upgrade to Serde 1.0 and languageserver-types 0.50

3

Upgrade RustLSP to the Serde 1.0.0 and languageserver-types 0.50.0. Using a stable version of Serde and a recent version of languageserver-types will let people more easily use rustdt-json_rpc. This pull...

12$: warn on '} if' on same line with no 'else'

5

```javascript if (x) { } if (y) { // warn please! } ``` ```javascript if (x) { } if (y) { } // unsure if we should warn... ``` Inspiration:...

8$: Warn on unused arrow expression

6

```js useEffect(() => { // BUG: async arrow function not used. async () => { const userReviewsForEachAudiobook = await Promise.all( reviewsUrlList.map((review) => { return fetch(review).then((res) => res.json()); }) ); };...

VS Code: confusing behavior for path-less file

2

1. create quick-lint-js.config: `{"globals": {"banana": true}}` 2. create a new file (Unnamed) 3. change the file's language to JavaScript 4. into the new file, write: `banana;` expected: no warning for...

9$: warn on 'keyof T[]' in type

1

In a TypeScript type, `keyof T[]` is the same as `number` (I think). The user likely meant `(keyof T)[]`. We should emit a warning, telling them to write either `number`...

error on 'x++.toString()'

4

`x++.toString()` seems to be invalid JS. Reject it and suggest parentheses.

12$: Improve diagnostic for myArray[a:b]

1

For `myArray[a:b]`, we can suggest writing `myArray.slice(a, b-a)` instead. Similarly, for `myArray[a:]`, we can suggest writing `myArray.slice(a)`. Similarly, for `myArray[:b]`, we can suggest writing `myArray.slice(0, b)`.

Incorrect Content-Type for /document/{document_id}/result response

2

The current DeepL OpenAPI schema says that responses for `/document/{document_id}/result` requests have `Content-Type: application/octet-stream`: https://github.com/DeepLcom/openapi/blob/189588784d656ca8937ee68590a474eb248cc038/openapi.yaml#L593-L606 However, this does not match my interaction with DeepL's production API server. The API can...