strager

Results 356 comments of strager

> Hello, I'd like to take on this task as part of classwork to contribute to an open source project. Awesome! I'm happy to help you with this. > What...

@cphamWSU Adding checks at the end of `parse_and_visit_for` sounds about right. Checking `has_leading_newline` for the `while` token sounds like a good idea too.

To implement this, we could sprinkle something like this throughout the parser: ```c++ Syntax_Explanation_Guard g = this->begin_syntax(u8"object literal"_sv); // or an enum /* parse the object literal here*/ /* end_syntax...

It looks like you're shrinking the proportional-width font size, but not the monospace font size. CSS breakpoints are based on the proportional-width font size. I think the correct solution would...

js-json-mode derives from js-mode. Possible fix: only lint `(unless (derived-mode-p 'js-json-mode))`. I think the correct thing to do would be to have a minor mode which registers Flymake correctly then...

> can you please assign it to me ? Sure! If you want payment, make sure you follow the instructions on https://quick-lint-js.com/hiring/.

Similar: ```js client.on('error', error { reportError(error); }); ``` Expected: "missing '=>' or ','"

The `looks_like_arrow_function_body` variable in `parse-expression.cpp` looks like a good place to start poking around.

Diag_Collector is gone. :+1: (EDIT: Almost.) Buffering_Diag_Reporter will take some work to rip out.

Rome is considering something similar: https://github.com/rome/tools/discussions/3663