rage icon indicating copy to clipboard operation
rage copied to clipboard

Parallelize STREAM

Open str4d opened this issue 3 years ago • 4 comments

Part of #271.

str4d avatar Nov 04 '20 21:11 str4d

Codecov Report

Merging #148 (4f72ab0) into main (456ce70) will increase coverage by 0.99%. The diff coverage is 63.96%.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   33.56%   34.55%   +0.99%     
==========================================
  Files          34       34              
  Lines        3081     3102      +21     
==========================================
+ Hits         1034     1072      +38     
+ Misses       2047     2030      -17     
Impacted Files Coverage Δ
age/src/primitives/stream.rs 58.13% <63.96%> (-1.35%) :arrow_down:
age/tests/test_vectors.rs 79.16% <0.00%> (-4.17%) :arrow_down:
age/src/format.rs 58.02% <0.00%> (-3.23%) :arrow_down:
age/src/protocol.rs 68.79% <0.00%> (-1.92%) :arrow_down:
age/src/keys.rs 80.00% <0.00%> (-1.82%) :arrow_down:
age/src/encrypted.rs 41.30% <0.00%> (-1.71%) :arrow_down:
age/src/plugin.rs 4.58% <0.00%> (-0.46%) :arrow_down:
age/src/util.rs 57.14% <0.00%> (ø)
age/src/error.rs 2.23% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 04 '20 21:11 codecov[bot]

Would be great to have this merged! Filippo doesn't seem to work on age much, so I think it's fine to make rage different in some regards.

paulmillr avatar Jan 02 '21 14:01 paulmillr

Would love to have something like this upstream in the aead crate 😉

tarcieri avatar Nov 08 '21 15:11 tarcieri

The current issue with this PR is that it provides way too little performance improvement for the CPU cost it incurs. I still need to dig into this and figure out why.

str4d avatar Nov 08 '21 16:11 str4d