Jack Grigg
Jack Grigg
In `yubikey 0.7`, `Certificate::generate_self_signed` took a `yubikey::certificate::PublicKeyInfo` argument as the key to generate the certificate for. This was an enum that was obtained from `yubikey::piv::generate` after passing in an `AlgorithmId`...
We currently require `subtle 2.3`: https://github.com/zcash/orchard/blob/9afad02db07d903d3f21b493d51c31b314841746/Cargo.toml#L43 However in `0.10.1` we started using `CtOption::into_option` (in the `pczt` module), which was added in `subtle 2.6`. We should either remove our usages of...
> **Note** >This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes...
I don't want `DerivationTool.derivePrivateUseMetadataKey` in the public API, but the way `DerivationTool` is constructed, I don't see how to expose this only to `AccountMetadataKey`.
Currently various public APIs of the SDK require passing the seed into them directly, making the assumption that the app can do so whenver that public API gets called (for...
#530 replaces the `UnifiedViewingKey` data class (which is incompatible with ZIP 316) with a `UnifiedFullViewingKey` data class (which will be compatible once #526 is closed). That change is intentionally minimal...
https://github.com/Electric-Coin-Company/zcash-android-wallet-sdk/blob/e37a35a8f0bffc7739e4327472d1b4a64b33112b/lightwallet-client-lib/src/main/java/co/electriccoin/lightwallet/client/internal/LightWalletClientImpl.kt#L150-L181 This code passes `tAddresses` to `lightwalletd`, but does not check that the response from `lightwalletd` only contains addresses that were in `tAddresses`, which means any bugs in `lightwalletd` (or...
Currently various public APIs of the SDK require passing the seed into them directly, making the assumption that the app can do so whenver that public API gets called (for...
Implemented on my laptop by @sonmarcho