Jack Grigg
Jack Grigg
We don't follow nightly for anything; its current purpose is to alert us to upcoming lint changes that might reach stable. Beta clippy is a better target for this, as...
The main task here is to add support for Orchard viewing keys in trial-decryption. Decrypted wallet transactions will gain the ability to contain received Orchard notes and spent Orchard nullifiers.
We need the ability to track Orchard notes in the wallet, and spend them. I think the simplest integration pathway is to add a `note_type` column to most tables, with...
The Bolt extensions is currently in https://github.com/boltlabs-inc/librustzcash on top of my initial `zip-wtps` branch. Once zcash/zips#224 is complete, we should rework that branch to use the updated TZE logic.
We have several places where we return `()` as an error placeholder. We should replace all of these with meaningful error types (even if they are just zero-sized structs).
`zcash_client_backend::welding_rig::scan_block` currently takes a slice of `ExtendedFullViewingKey`, using the indices within the slice as the account number. This makes the assumption that the caller has a single tree of keys...
We don't appear to have one, which has led to various parts of the codebase using either `[u8; 32]`, `Vec`, or `&[u8]` in their APIs. We should have a `struct...
This would ideally be generic over the particular extension type, which might require some refactoring of the `zcash_primitives` crate. If that requires too much work, then let's just add support...
https://github.com/zcash/librustzcash/pull/66#discussion_r271473341
e.g. https://github.com/zcash/librustzcash/pull/92#discussion_r313614710 There are strategies we can use for this, such as creating a "last raised error" FFI function.