Jack Grigg

Results 1058 comments of Jack Grigg

I made another point I noted during the Office Hours discussion that isn't directly relevant to the topic of extracting an FPGA chip, but is illustrative of the difference in...

Now that we have address book encryption, when initializing the SDK with a UFVK we'd also want to enable bringing in the corresponding address book key (whether that is separately,...

`v_tx_outputs` queries notes twice: https://github.com/zcash/librustzcash/blob/3ccc14f501c569bc948735d6320b09ce89c1d57c/zcash_client_sqlite/src/wallet/init.rs#L957-L970 https://github.com/zcash/librustzcash/blob/3ccc14f501c569bc948735d6320b09ce89c1d57c/zcash_client_sqlite/src/wallet/init.rs#L983-L997 Both of these join `v_received_notes` and `sent_notes`, so there is immediate possibility of duplication of change notes (which are added to both tables). What...

I suggested in the call that we follow a "nightly -> beta -> stable" workflow inspired by the Rust development workflow. We would add a `beta` feature flag, and a...

#716 adds the initial harness corresponding to https://github.com/zcash/halo2/issues/707#issuecomment-1344870500. It notes that we might augment it with a branching approach later (more specifically in concert with a feature that needs it,...

Hmm, it might actually be better to write a separate "simple example", because `halo2_gadgets` does not (currently) have gadgets for arbitrary integer addition (only ECC math). So it would probably...

Mempool metrics from `zcashd` for the past 4 days show a resumption in this behaviour: ![image](https://github.com/zcash/zcash/assets/4993799/93d4e30b-4e9f-401b-9ec3-b30d83cbb9c5) Spot-checking the contents of the mempool just now, every spam transaction has 50 logical...

AFAICT we don't install any CMake documentation. The files that the CMake installer is placing in `depends/*/native/doc/cmake-*/` are copies of the various copyright notices, which add up to a few...

We do however build CTest (and its associated binaries and libraries) during the `native_cmake` installer; we probably don't need to do that as we don't run any of the dependencies'...

CI is failing because the `macos-11` runner is having artificial brown-outs ahead of it being removed in 4 days. I've opened #6905 to switch CI to `macos-12`; once that merges,...