stp icon indicating copy to clipboard operation
stp copied to clipboard

Install cadiback dependency

Open gussmith23 opened this issue 10 months ago • 4 comments

Feel free to make whatever edits you want to this -- was my quick solution to the problem.

Closes #481.

gussmith23 avatar Apr 23 '24 01:04 gussmith23

@aytey would love help on this. Unsure why CI is failing. This was the minimal set of changes to get it to work on my side, but I'm sure there's more that's needed!

gussmith23 avatar Apr 24 '24 20:04 gussmith23

@aytey would love help on this. Unsure why CI is failing. This was the minimal set of changes to get it to work on my side, but I'm sure there's more that's needed!

I'll try to look on Friday -- sorry.

As a note, I'm not sure if appveyor has been happy "in quite a while", so it failing might be something to ignore.

aytey avatar Apr 24 '24 20:04 aytey

I just approved the CI for gcc/clang -- sorry for not doing that sooner.

aytey avatar Apr 24 '24 20:04 aytey

Unsure why clang passed and gcc failed. I expected both to fail. gcc-built version getting errors like this:

/home/runner/work/stp/stp/build/tests/unit-tests/MergeSame_TestTests: error while loading shared libraries: libcadiback.so: cannot open shared object file: No such file or directory

This is because deps/cadiback/libcadiback.so and deps/cadical/build/libcadical.so need to be installed alongside STP. Currently, I don't think that's happening. I'm not quite sure what the right way is to make that happen with CMake. I'm assuming it's a simple fix!

gussmith23 avatar Apr 24 '24 23:04 gussmith23

Unsure why clang passed and gcc failed. I expected both to fail. gcc-built version getting errors like this:

/home/runner/work/stp/stp/build/tests/unit-tests/MergeSame_TestTests: error while loading shared libraries: libcadiback.so: cannot open shared object file: No such file or directory

This is because deps/cadiback/libcadiback.so and deps/cadical/build/libcadical.so need to be installed alongside STP. Currently, I don't think that's happening. I'm not quite sure what the right way is to make that happen with CMake. I'm assuming it's a simple fix!

Thanks for the fix. It's weird to me too, that the gcc-built version is failing. I don't know why either.

TrevorHansen avatar Jun 06 '24 06:06 TrevorHansen