react-native-version icon indicating copy to clipboard operation
react-native-version copied to clipboard

Syntax Error while versioning iOS

Open aruldd opened this issue 6 years ago • 25 comments

PS F:\Shared Desktop\ROBOCRAZE\RnD\alphacare\hospital_app_react> yarn version --minor yarn version v1.6.0 warning ..\package.json: No license field info Current version: 0.1.0-beta question New version: error Invalid semver version question New version: 0.2.0 info New version: 0.2.0 $ react-native-version [RNV] Versioning Android... [RNV] Android updated [RNV] Versioning iOS... [RNV] SyntaxError: Expected """, "\'", "\"", "\n", or [^\"] but "\" found.

After setting up post version hook, running the command yarn version --minor produces this error.

Platform: Windows 10

aruldd avatar May 28 '18 13:05 aruldd

Looks similar to: https://github.com/stovmascript/react-native-version/issues/38#issuecomment-372974523 and: https://github.com/stovmascript/react-native-version/issues/38#issuecomment-385656056

stovmascript avatar May 28 '18 13:05 stovmascript

@aruldd Is it possible you have manually set up some paths in your Xcode project file?

stovmascript avatar May 28 '18 17:05 stovmascript

Found the issue, the problem comes from React Native made in Windows that will have backslashed paths inside pbxproj. It's not a problem from your package at all @stovmascript . Check strings that are like this:

"\"$(SRCROOT)/$(TARGET_NAME)\"",
or
"$(SRCROOT)\..\node_modules\react-xxxx",

and change them to

"$(SRCROOT)/$(TARGET_NAME)",
accordingly
"$(SRCROOT)/../node_modules/react-xxxx",

VinceBT avatar May 30 '18 22:05 VinceBT

@VinceBT Awesome, I'll capture this message and print out something more meaningful.

stovmascript avatar May 31 '18 06:05 stovmascript

@VinceBT I also suspect that it's more of an issue with react-native link because a newly initialized project doesn't have any $(SRCROOT) strings yet. Which would explain why everything worked for me in: https://github.com/stovmascript/react-native-version/issues/38#issuecomment-383421578.

stovmascript avatar May 31 '18 06:05 stovmascript

It's just because Windows uses \ instead of / for paths and when paths are written to pbxproj when using react-native link, they will contain backslashes, it still works when your compile on a Mac, but it will crash with the pbxproj-dom parser package that you use. You could maybe add a "Common issues" page on your README for future users.

VinceBT avatar May 31 '18 08:05 VinceBT

@aruldd Tell us if it worked for you so @stovmascript can close

VinceBT avatar Jun 01 '18 12:06 VinceBT

I'm getting this issue when running on Mac OSX, is that expected? I'm on 3.2.0

Maushundb avatar Nov 25 '19 22:11 Maushundb

Yeah there seems to be some paths in pbxproj that cocoapods installs that has the windows syntax as well. Had to go in and edit them manually, now it works. This does happen on macs as well apparently, might wanna update docs.

Maushundb avatar Nov 25 '19 23:11 Maushundb

Hmm, this seems like a bug with cocoapods, or even some specific packages. I'm wondering if we could find the offending upstream code and report it...

stovmascript avatar Nov 26 '19 09:11 stovmascript

Or we could patch pbxproj-dom or find an alternative.

stovmascript avatar Nov 26 '19 09:11 stovmascript

If it helps, offending line was:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \\\n../node_modules/react-native/scripts/react-native-xcode.sh\n";

Had to remove the \\ from \\\n

from https://www.npmjs.com/package/@sentry/react-native

Maushundb avatar Nov 26 '19 17:11 Maushundb

I have a more "funny" case. My error was "SyntaxError: Expected """, "\'", "\"", "\n", or [^\"] but "\" found.", so I searched for \ in the project.pbxproj and the only place where it was present was

shellScript = "# Name of the resource we're selectively copying\nFILENAME=GoogleService-Info.plist\n\nBUILD_TYPE=$(echo ${CONFIGURATION} | sed -E \"s/\\s*(Release|Debug) \\s*//\")\nORIGINAL_PATH=${PROJECT_DIR}/${TARGET_NAME}/Firebase/${BUILD_TYPE}/${FILENAME}\nDESTINATION_DIR=${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.app\n\n# Make sure the prod version of GoogleService-Info.plist exists\necho \"Looking for ${ORIGINAL_PATH}\"\nif [ ! -f $ORIGINAL_PATH ]\nthen\n echo \"No ${FILENAME} found for build type ${BUILD_TYPE}. Please ensure it's in the proper directory.\"\n exit 1\nfi\n\necho \"Will copy ${ORIGINAL_PATH} to final destination: ${DESTINATION_DIR}\"\n\ncp \"${ORIGINAL_PATH}\" \"${DESTINATION_DIR}\"\n";

So basically it failed parsing the shell script, which is kind of weird. I removed this script and the error was gone, so it's this indeed. I will change my script to fix this, but it shouldn't have happened in the first place.

vladwhd avatar Jan 24 '20 09:01 vladwhd

If it helps, offending line was:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \\\n../node_modules/react-native/scripts/react-native-xcode.sh\n";

Had to remove the \\ from \\\n

from https://www.npmjs.com/package/@sentry/react-native

your command line appers like this?

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \n../node_modules/react-native/scripts/react-native-xcode.sh\n";

fabricio0915 avatar Feb 18 '20 11:02 fabricio0915

Facing the same problem after adding a custom build script, have been using the library without any issues for a year, but stuck now. Lots of backslashes in the script to escape quotes and spaces, so not sure how to fix it.

EDIT: I've created an issue in pbxproj-dom to see if they have any ideas on a fix

sanjaypojo avatar May 19 '20 18:05 sanjaypojo

Just to clarify though -- I'm facing this issue on macOS. Here's the exact error:

[RNV] SyntaxError: Expected ",", "/*", or [ \t\n\r] but "B" found.

EDIT: Managed to resolve the issue by checking through my build settings and removing some \ characters as suggested

sanjaypojo avatar May 28 '20 21:05 sanjaypojo

I have fixed this issue by moving the script, which caused the error, from project.pbxproj to separate .sh file and then just added a reference to that file. Also you should make your sh file executable by chmod +x script.sh

Screenshot 2021-05-18 at 17 53 52

otkach-yara avatar May 18 '21 14:05 otkach-yara

In our case it was newest react with @sentry/react-native having offending lines in shell script (copied from official Sentry documentation about workaround for RN >0.69) Here is the working shell script line in case anyone needs it:

/bin/sh -c "$WITH_ENVIRONMENT '$SENTRY_CLI_PATH react-native xcode $REACT_NATIVE_XCODE'"

bimusiek avatar Nov 30 '22 15:11 bimusiek

Here is the final version of working shellScript in Sentry v5 and RN v0.71

shellScript = "set -e\nexport SENTRY_PROPERTIES=sentry.properties\nexport EXTRA_PACKAGER_ARGS=\"--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map\"\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\nSENTRY_CLI_PATH=\"../node_modules/@sentry/cli/bin/sentry-cli\"\n/bin/sh -c \"$WITH_ENVIRONMENT $SENTRY_CLI_PATH react-native xcode\n$REACT_NATIVE_XCODE\"\n/bin/sh ../node_modules/@sentry/react-native/scripts/collect-modules.sh\n";

marcinniemirski avatar May 24 '23 15:05 marcinniemirski

I'm experiencing this issue with Sentry.

I suspect this line is causing the problem, but I don't know how to fix it:

shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport EXTRA_PACKAGER_ARGS=\"--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map\"\nset -e\n\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT \\\"../node_modules/@sentry/cli/bin/sentry-cli react-native xcode $REACT_NATIVE_XCODE\\\"\"\n\n/bin/sh ../node_modules/@sentry/react-native/scripts/collect-modules.sh\n";

Any way to solve this?

n-ii-ma avatar Jun 13 '23 08:06 n-ii-ma

i have the same error on MacOs now. any one fixed this please ?

alainib avatar Aug 23 '23 10:08 alainib

i have the same error on MacOs now. any one fixed this please ?

were you able to fix it?

erickgtzh avatar Sep 25 '23 00:09 erickgtzh

SyntaxError: Expected """, "\'", "\"", "\n", or [^\"] but "\" found.

similar to above it was Sentry shell script. I am on a mac. shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport ....."

in several places I had to replace $WITH_ENVIRONMENT \\\ with $WITH_ENVIRONMENT \ and $REACT_NATIVE_XCODE\\\ with $REACT_NATIVE_XCODE\

29er avatar Oct 20 '23 17:10 29er

Faced the same issue with Mac. Resolved with changing

shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target\\ Support\\ Files/Pods-tracemoe_react_native/expo-configure-project.sh\"\n";

to

shellScript = "# This script configures Expo modules and generates the modules provider file.\nbash -l -c \"./Pods/Target' 'Support' 'Files/Pods-tracemoe_react_native/expo-configure-project.sh\"\n";

The key: \\ to ' ' Root reason - the file path with space in it.

Leslie-Wong-H avatar Dec 28 '23 07:12 Leslie-Wong-H