storybook
storybook copied to clipboard
bug: storybook angular format is optional
What I did
Small change to angular framework, to make format as optional and stopping it enforced all the time in preview source
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
- [ ] stories
- [x] unit tests
- [x] integration tests
- [ ] end-to-end tests
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
- [x] Add or update documentation reflecting your changes
- [x] If you are deprecating/removing a feature, make sure to update MIGRATION.MD
Checklist for Maintainers
-
[x] When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts -
[x] Make sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.
core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 7659b2230788a675f101c0d740e16981aeeb79fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 target
Sent with 💌 from NxCloud.
Hey @64BitAsura thanks for your contribution. Would you mind creating a GH issue explaining what exactly you're trying to solve in this PR? It's a bit unclear right now. If you elaborate the issue we can better review this and see whether there are more changes needed to be done. Thanks!
Hey @64BitAsura thanks for your contribution. Would you mind creating a GH issue explaining what exactly you're trying to solve in this PR? It's a bit unclear right now. If you elaborate the issue we can better review this and see whether there are more changes needed to be done. Thanks!
As requested https://github.com/storybookjs/storybook/issues/28341
Thanks for your contribution! LGTM!