storybook
storybook copied to clipboard
Fix function prop rendering as `noRefCheck` in storybook docs
Related to #17701, not quite the same i think.
What I did
According to react-element-to-jsx-string
, function props are rendered as
function noRefCheck() {}
However, I found that for me, they're rendered without the space between the brackets.
-function noRefCheck() {}
+function noRefCheck(){}
As such, I updated the replacement regex to account for both cases, which fixes my problem.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
- [ ] stories
- [ ] unit tests
- [ ] integration tests
- [ ] end-to-end tests
Manual testing
Visuals:
Before | After |
---|---|
Documentation
- [ ] Add or update documentation reflecting your changes
- [ ] If you are deprecating/removing a feature, make sure to update MIGRATION.MD
Checklist for Maintainers
-
[ ] When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
-
[ ] Make sure this PR contains one of the labels below:
Available labels
-
bug
: Internal changes that fixes incorrect behavior. -
maintenance
: User-facing maintenance tasks. -
dependencies
: Upgrading (sometimes downgrading) dependencies. -
build
: Internal-facing build tooling & test updates. Will not show up in release changelog. -
cleanup
: Minor cleanup style change. Will not show up in release changelog. -
documentation
: Documentation only changes. Will not show up in release changelog. -
feature request
: Introducing a new feature. -
BREAKING CHANGE
: Changes that break compatibility in some way with current major version. -
other
: Changes that don't fit in the above categories.
-
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core
team here.
core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>