storybook icon indicating copy to clipboard operation
storybook copied to clipboard

Published 20 hours ago • verified publisher icon storybookjs

[Bug]: SB8 UI, Search results on dark mode are tough to read

Open domyen opened this issue 1 year ago • 1 comments

Describe the bug

The search results for SB8 UI dark mode are currently a shade of gray that's tough to read. I'd expect the title to be closer to to white. image

To Reproduce

  1. Spin up an SB8 project (like this one)
  2. Use the dark theme
  3. Search for something
  4. See the search result color

System

No response

Additional context

No response

domyen avatar Feb 13 '24 12:02 domyen

+1, would also expect white in dark mode

joevaugh4n avatar Feb 13 '24 14:02 joevaugh4n

Can I Have this issue?

sakit0 avatar Feb 20 '24 21:02 sakit0

Hi @domyen @vanessayuenn . Could u please assign this to me.

sash9696 avatar Feb 21 '24 04:02 sash9696

Before someone starts on this, please let's wait on the feedback of some of our designers.

cc @cdedreuille, @MichaelArestad

valentinpalkovic avatar Feb 21 '24 22:02 valentinpalkovic

Yes I believe the title should be white. Not sure what went wrong here when we recoded it.

cdedreuille avatar Feb 21 '24 23:02 cdedreuille

@sakit0 @sash9696 we'd welcome a PR fixing this (changing the text to white as per @cdedreuille).

Be sure to check the contribution guide and hop onto the Storybook Discord if you need any help getting started. Looking forward to your contribution! ✨

vanessayuenn avatar Feb 23 '24 18:02 vanessayuenn