storybook
storybook copied to clipboard
UI: Improve how the addon panel work on mobile
What I did
Closes #24424
On the new mobile layout we used to show the addon panel above the canvas. In cases where you use layout: centred
the addon panel would hide quite a large part of the UI. To fix that, I replicated the desktop behaviour and made the addon panel appear below the canvas.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
- [ ] stories
- [ ] unit tests
- [ ] integration tests
- [ ] end-to-end tests
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
- [ ] Add or update documentation reflecting your changes
- [ ] If you are deprecating/removing a feature, make sure to update MIGRATION.MD
Checklist for Maintainers
-
[ ] When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
-
[ ] Make sure this PR contains one of the labels below:
Available labels
-
bug
: Internal changes that fixes incorrect behavior. -
maintenance
: User-facing maintenance tasks. -
dependencies
: Upgrading (sometimes downgrading) dependencies. -
build
: Internal-facing build tooling & test updates. Will not show up in release changelog. -
cleanup
: Minor cleanup style change. Will not show up in release changelog. -
documentation
: Documentation only changes. Will not show up in release changelog. -
feature request
: Introducing a new feature. -
BREAKING CHANGE
: Changes that break compatibility in some way with current major version. -
other
: Changes that don't fit in the above categories.
-
🦋 Canary release
This pull request has been released as version 0.0.0-pr-25787-sha-ce3d85aa
. Try it out in a new sandbox by running npx [email protected] sandbox
or in an existing project with npx [email protected] upgrade
.
More information
Published version | 0.0.0-pr-25787-sha-ce3d85aa |
Triggered by | @yannbf |
Repository | storybookjs/storybook |
Branch | charles-fix-mobile-addon-panel |
Commit | ce3d85aa |
Datetime | Mon Jan 29 11:38:07 UTC 2024 (1706528287 ) |
Workflow run | 7695438461 |
To request a new release of this pull request, mention the @storybookjs/core
team.
core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25787