storybook icon indicating copy to clipboard operation
storybook copied to clipboard

[Feature Request]: Add Ember 5 support

Open valentinpalkovic opened this issue 1 year ago • 2 comments

Describe the bug

Currently, when executing npx sb@next init in a fresh Ember 5 project, the CLI aborts and returns the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/ember-source
npm ERR!   dev ember-source@"~5.5.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer ember-source@"~3.28.1 || ^4.0.0" from @storybook/[email protected]
npm ERR! node_modules/@storybook/ember
npm ERR!   dev @storybook/ember@"^8.0.0-alpha.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/valentinpalkovic/.npm/_logs/2023-12-29T14_26_23_267Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/valentinpalkovic/.npm/_logs/2023-12-29T14_26_23_267Z-debug-0.log

To Reproduce

  1. ember new ember-app
  2. cd ember-app
  3. npx sb@next init

System

Storybook Environment Info:

  System:
    OS: macOS 14.0
    CPU: (10) arm64 Apple M1 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.19.0 - ~/.nvm/versions/node/v18.19.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.20.0/bin/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v18.19.0/bin/npm <----- active
    pnpm: 8.11.0 - ~/.nvm/versions/node/v16.20.0/bin/pnpm
  Browsers:
    Chrome: 120.0.6099.129
    Safari: 17.0

Additional context

No response

valentinpalkovic avatar Dec 29 '23 14:12 valentinpalkovic

cc @francois2metz, @gossi

valentinpalkovic avatar Dec 29 '23 14:12 valentinpalkovic

Looks like this line doesn't widen the support for version 5 and above:

https://github.com/storybookjs/storybook/blob/5a83f53ee2040e2a60af83999ad574c8c29ad208/code/frameworks/ember/package.json#L54

should be:

"ember-source": "~3.28.1 || >=4.0.0",

gossi avatar Jan 29 '24 14:01 gossi