storybook icon indicating copy to clipboard operation
storybook copied to clipboard

[Bug]: "Setup controls >" URL cannot be disabled

Open hieucd04 opened this issue 1 year ago • 3 comments

Describe the bug

I followed this guide: https://storybook.js.org/docs/react/essentials/controls#disable-controls-for-specific-properties ... where I explicitly set control: false as mentioned there and it works. However, when I hover my mouse over the disabled control a Setup controls > URL is displayed.

Currently, at Storybook 7.4.6, there are no way to disable that behavior (... or my Googling skill isn't good enough?). That URL appears in production build of Storybook as well (sb build -o out-dir) which is pointless from my perspective. How come our clients, who know nothing about coding and only care about the beauty of React components, need to view that URL?

link

hieucd04 avatar Oct 14 '23 11:10 hieucd04

@cdedreuille Can you take a look? It seems that "Setup controls" doesn't respect, whether a control field is disabled or not.

valentinpalkovic avatar Oct 14 '23 17:10 valentinpalkovic

Using

control: { 
  type: {}
}

removes the link.

control: {
  type: {},
  disable: true
}

does not

peschee avatar Dec 13 '23 09:12 peschee

I confirm that the disable property was not added to the "setup control" link when we added this feature. I'll take this one on to make sure it does.

cdedreuille avatar Feb 19 '24 11:02 cdedreuille

We just talked about this with @kasperpeulen and he is taking over this task.

cdedreuille avatar Feb 20 '24 15:02 cdedreuille