storybook icon indicating copy to clipboard operation
storybook copied to clipboard

UI: remove ActionBar background style

Open eungyeole opened this issue 1 year ago • 1 comments

What I did

ActionBar has a background style, but this is not necessary, which causes a problem of breaking the style as shown in the image below

image 스크린샷 2023-09-23 오후 6 43 47

  • remove ActionBar Container background style

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • [ ] stories
  • [ ] unit tests
  • [ ] integration tests
  • [ ] end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • [ ] Add or update documentation reflecting your changes
  • [ ] If you are deprecating/removing a feature, make sure to update MIGRATION.MD

Checklist for Maintainers

  • [ ] When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • [ ] Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

eungyeole avatar Sep 23 '23 09:09 eungyeole

I'll take a proper look at this one very soon.

cdedreuille avatar Feb 19 '24 12:02 cdedreuille

I think this background is necessary in some addons as this component is used in many places. I would be quite hesitant to remove it for now as it could have side effects in other places. That said, we are looking at improving this design as I don't believe having the Copy button on top is a pattern we should keep.

So if that's ok I'm going to close this one for now and fix it with our new design.

cdedreuille avatar May 13 '24 08:05 cdedreuille

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bb179b0601369aa68a7a4c2ab397197357a5767a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar May 13 '24 08:05 nx-cloud[bot]