storybook icon indicating copy to clipboard operation
storybook copied to clipboard

Published 20 hours ago • verified publisher icon storybookjs

Viewport: Fix the `defaultOrientation` config option

Open jpzwarte opened this issue 1 year ago • 5 comments

So https://github.com/storybookjs/storybook/pull/21048 was actually broken. This fixes that (tested this time!).

jpzwarte avatar Mar 10 '23 13:03 jpzwarte

@shilman I think this is actually a good bugfix to merge into 7.0. WDYT?

ndelangen avatar Mar 14 '23 08:03 ndelangen

@jpzwarte did you intend to delete the branch (which auto-closes PRs)?

ndelangen avatar Mar 15 '23 12:03 ndelangen

NO :(

jpzwarte avatar Mar 15 '23 12:03 jpzwarte

I removed my local fork, which caused this PR to be closed :( Was not my intention.

jpzwarte avatar Mar 15 '23 13:03 jpzwarte

@ndelangen Can we merge this one?

valentinpalkovic avatar Mar 17 '23 13:03 valentinpalkovic

I can't update this @jpzwarte

(next) % git remote add jpzwarte [email protected]:jpzwarte/storybook.git                                                                                                                                                                                                 ~/Projects/Storybook/core
git fetch jpzwarte fix/viewport-orientation
git switch --track jpzwarte/fix/viewport-orientation
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: invalid reference: jpzwarte/fix/viewport-orientation

ndelangen avatar Apr 06 '23 08:04 ndelangen

@ndelangen see the new PR: https://github.com/storybookjs/storybook/pull/21962

jpzwarte avatar Apr 06 '23 08:04 jpzwarte