storybook icon indicating copy to clipboard operation
storybook copied to clipboard

Build: Bundle lib/docs-tools & lib/instrumenter with ts-up

Open darenbt opened this issue 2 years ago • 1 comments

Issue:

Reference: https://github.com/storybookjs/storybook/issues/18732

What I did

Converted lib/docs-tools and lib/instrumenter to use tsup bundling script.

How to test

  • [ ] Is this testable with Jest or Chromatic screenshots? No
  • [ ] Does this need a new example in the kitchen sink apps? No
  • [ ] Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

darenbt avatar Sep 17 '22 04:09 darenbt

Hello @darenbt Thank you for contributing!

I am trying to update your feature branch with new changes in next-branch, but GitHub is refusing:

(build/lib-docs-tools+lib-instrumenter-tsup)⚡ % git push                                                                                                              ~/Projects/Storybook/core/code
Enumerating objects: 44, done.
Counting objects: 100% (44/44), done.
Delta compression using up to 10 threads
Compressing objects: 100% (16/16), done.
Writing objects: 100% (16/16), 2.04 KiB | 2.04 MiB/s, done.
Total 16 (delta 15), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (15/15), completed with 14 local objects.
To https://github.com/darenbt/storybook.git
 ! [remote rejected]       build/lib-docs-tools+lib-instrumenter-tsup -> build/lib-docs-tools+lib-instrumenter-tsup (refusing to allow an OAuth App to create or update workflow `.github/workflows/generate-repros-next.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/darenbt/storybook.git'

I don't think there's something you can do to make that work, but perhaps you could merge in next from the upstream remote yourself, to see if the recent changes in next fix the CI issues on this PR? 🙏 Thanks!

ndelangen avatar Oct 05 '22 14:10 ndelangen