storybook icon indicating copy to clipboard operation
storybook copied to clipboard

Published 20 hours ago • verified publisher icon storybookjs

Feat/addons docs tsup

Open Saunved opened this issue 2 years ago • 3 comments

Issue: https://github.com/storybookjs/storybook/issues/18732

What I did

Followed the instructions on the issue mentioned above

How to test

  • [ ] Is this testable with Jest or Chromatic screenshots? Yes, with CI
  • [ ] Does this need a new example in the kitchen sink apps? No
  • [ ] Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

Saunved avatar Jul 25 '22 19:07 Saunved

@ndelangen

Based on this deployment failure: https://app.netlify.com/sites/storybookjs/deploys/62def0a92e5b730008aa0ea6 Looks like the docs addon needs to export angular. I can't spot it in the old build, so not sure how it was being accessed.

I am not sure how to export angular from this repository with the new build system. Do I add it to exports? Would it be the same for ember and web-components?

Saunved avatar Jul 25 '22 20:07 Saunved

@Saunved Seems this addon is a bit more involved than the others.. Let's revisit this one last.

ndelangen avatar Aug 01 '22 18:08 ndelangen

Yes, it seems a bit complicated. I'll push the remaining ones this week for review!

Saunved avatar Aug 01 '22 19:08 Saunved

Hello @Saunved sorry this PR was somewhat neglected.. it turned out this package was quite complex, and so I took it over at some point for forgot to inform you.

Sorry about that. I hope you don't mind me closing this PR now.

Thank you for your time, energy and effort put into this (and the others) PR. It's greatly appreciated!

ndelangen avatar Nov 19 '22 00:11 ndelangen