Custom tabs don't have access to full screen toggle buttons

[micahgodbolt]

Describe the bug Canvas tab has a button to go, and return from full screen (among others). Switching to docs or custom tabs don't give you those tabs (nor do I see a way to add them).

This leaves a use possibly sitting in the docs tab not able to return from full screen mode.

To Reproduce Steps to reproduce the behavior:

1. Go to a storybook page
2. Click on 'Full Screen button (or type F)'
3. Click on Docs tab
4. Note that you can't escape full screen without either knowing the keyboard shortcut or returning to Canvas tab

Expected behavior User can enter/exit full screen from any page tabs

Screenshots

[Tomastomaslol]

What would be the best solution for this?

Add the toggle fullscreen button in the docs tab? Programmatically exit fullscreen when the user navigates to the Docs page?

Any other suggestions? 🙂

[micahgodbolt]

Short term I'd suggest those top 3 icons show up on all tabs as we created a custom tab that would certainly benefit from full screen mode as well (so exiting full screen sounds annoying).

Longer term, it'd be nice to customize that whole icon bar, using default buttons and/or adding custom buttons.

[shilman]

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.0-alpha.28 containing PR #12861 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

[micahgodbolt]

@shilman ya'll are mind reader!

[micahgodbolt]

@shilman oh shoot....what about custom tabs? I'm going to assuming that story/docs are the only tabs they will show in right now.

[micahgodbolt]

@shilman i changed the title to specifically point out 'custom' tabs....can we re-open this?

[micahgodbolt]

Can confirm, installed prerelease and docs has the close button, but our custom tab does not

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!