storybook icon indicating copy to clipboard operation
storybook copied to clipboard

Addons not updated while moving between stories at composed storybook

Open rannyeli opened this issue 4 years ago • 7 comments

Addons updated only when i'm focusing on them. Here is a gif to represent the problem: Peek 2020-08-27 15-16

System:

    OS: Linux 5.4 Ubuntu 18.04.5 LTS (Bionic Beaver)
    CPU: (8) x64 Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz
  Binaries:
    Node: 14.5.0 - ~/.nvm/versions/node/v14.5.0/bin/node
    Yarn: 1.22.4 - /usr/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v14.5.0/bin/npm
  Browsers:
    Chrome: 84.0.4147.135
    Firefox: 79.0
  npmPackages:
    @storybook/addon-actions: ^6.0.18 => 6.0.18 
    @storybook/addon-docs: ^6.0.18 => 6.0.18 
    @storybook/addon-knobs: ^6.0.18 => 6.0.18 
    @storybook/addon-links: ^6.0.18 => 6.0.18 
    @storybook/addon-storysource: ^6.0.18 => 6.0.18 
    @storybook/addons: ^6.0.18 => 6.0.18 
    @storybook/preset-create-react-app: ^3.1.4 => 3.1.4 
    @storybook/react: ^6.0.18 => 6.0.18 
    @storybook/theming: ^6.0.18 => 6.0.18

rannyeli avatar Aug 27 '20 12:08 rannyeli

Hey, any updates?

syncush avatar Aug 31 '20 06:08 syncush

@syncush do both storybooks have addon-storysource installed and is it the same version?

@ndelangen any thoughts on this?

shilman avatar Aug 31 '20 10:08 shilman

@shilman yes they both have addon-storysource installed with the same version 6.0.18, it appears on addon-knobs and addon-actions as well

rannyeli avatar Aug 31 '20 11:08 rannyeli

I have a similar issue where one storybook is using controls (version 6) and another storybook is using knobs (stories built on storybook 5.3).

Only the action tab shows up for all stories in the composition, knobs never shows up in the 5.3 storybook

Screen Shot 2020-09-12 at 11 52 48 PM

inthegreenwild avatar Sep 13 '20 04:09 inthegreenwild

Composition -right now- doesn't support taking manage-addons from the composed storybook into the parent storybook.

We're looking into making addons more stand-alone and thus be possible to be loaded without them being in the bundle.

But it does look like addon panels might not be updating correctly when the selected story is from a composed storybook.

ndelangen avatar Sep 25 '20 07:09 ndelangen

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

stale[bot] avatar Dec 25 '20 20:12 stale[bot]

bump

syncush avatar Dec 26 '20 10:12 syncush