react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Feature request] Add nesting of story tree in React Native

Open Gongreg opened this issue 6 years ago • 16 comments

Work summary

It would help a lot to display story list as a full screen list instead of half screen. Since now the story names are sometimes too long to properly fit the sidebar.

Some people have requested functionality to display a nested tree instead of one level list (#2833). It shouldn't be too difficult to implement (I hope).

The main concern I have is that adding multiple level tree can be a performance issue in RN.

Where to start

You need to setup CRNA example and try to work on App/OnDeviceUI files.

Acceptance criteria

  • Stories displayed in full screen instead of a sidebar.
  • Stories are nested.

Who to contact

You can contact me or anyone from contributors in slack.

Gongreg avatar Jul 20 '18 11:07 Gongreg

@Gongreg regarding nested stories, did you try to use a / separator in story names? It does the job for me. But alas this feature is not documented.

sesm avatar Jul 30 '18 22:07 sesm

Hey @sesm, it does work but it works differently than in browser. What I am thinking about is implementing full tree view just like in the browser.

image

Something like this but inside the simulator view.

Gongreg avatar Aug 02 '18 08:08 Gongreg

@Gongreg We could decide to do one of these things:

  1. We re-implement the treeview in RN We can likely re-use a ton, because of the way I wrote it (separating the visual from state)
  2. We write the UI of the treeview in such a way it's renderable in RN
  3. We embed the treeview in a webview in RN and communicate with it over a channel We'd re-use the code in it's entirety and complexity is lowest

ndelangen avatar Oct 13 '18 19:10 ndelangen

@ndelangen I would like to try out web view approach. Lets have a session some time in the future.

Gongreg avatar Oct 18 '18 09:10 Gongreg

Any progress on this?

Isakdl avatar Dec 17 '18 16:12 Isakdl

Hey, there was no progress from my side. @ndelangen, would it be possible to create a bundle with treeview now? Or the new treeview is still WIP?

Gongreg avatar Dec 18 '18 14:12 Gongreg

@Gongreg regarding nested stories, did you try to use a / separator in story names? It does the job for me. But alas this feature is not documented.

It doesn't seem to do anything for me, other than make the name longer. Am I missing something? Screen Shot 2019-03-18 at 8 07 19 PM

lancesnider avatar Mar 19 '19 03:03 lancesnider

@lancesnider This feature has not been implemented, which is why the issue is still open

shilman avatar Mar 19 '19 03:03 shilman

Any progress?

k-sav avatar Nov 06 '20 09:11 k-sav

Any updates on this feature ?

felixolivares avatar Nov 18 '21 16:11 felixolivares

@felixolivares not been developed yet but all PR's are welcome. Working through issues when I can, this is one that I want to fix in 6.0.

dannyhw avatar Nov 18 '21 17:11 dannyhw

Hey everyone! Any update on this issue?

Katia-Toboleva avatar Jun 08 '22 13:06 Katia-Toboleva

@Katia-Toboleva I've not had time for it yet but its still on my mind to look at it. My idea for this one was to add it after v6 comes out.

dannyhw avatar Jun 08 '22 18:06 dannyhw

Hi @dannyhw ! Thanks for an update! Is there any timescale for that?

Katia-Toboleva avatar Jun 09 '22 08:06 Katia-Toboleva

@Katia-Toboleva hey, sorry its really hard to give timelines because it just depends on when I have free time or when others want to contribute.

dannyhw avatar Jun 09 '22 10:06 dannyhw

Ok, no worries! Thanks for looking after this anyway :)

Katia-Toboleva avatar Jun 09 '22 14:06 Katia-Toboleva

please try the new alpha version 6.5.5-alpha.0 which has an implementation of this

dannyhw avatar Jul 14 '23 10:07 dannyhw