Add check for src-less scripts in preview

Open thrashr888 opened this issue 3 years ago • 1 comments

My app uses ember-cli-segment, which adds a script tag (something similar to a Google Analytics tag) to my HTML. It ends up in the preview with a <script type="text/javascript"> tag. The build fails with a Cannot read property 'indexOf' of undefined error on line 121 here, then on line 140 once that's fixed. This PR adds checks to avoid calling indexOf on script tags without src attributes.

I looked at the test and I'm not sure how you'd want to test it? I imagine the existing tests might fail if a Object { "type": "text/javascript", }, is added, but now they'll pass?

Thanks.

Mar 31 '22 02:03 thrashr888

Also ran into this. The fix in this PR seems to work on my end, but I do get a non-blocking error within storybook though

Aug 25 '23 19:08 chasegiunta